adding solution to py-herbivores-and-carnivores #1370
Conversation
There was a problem hiding this comment.
Great job on implementing the class hierarchy for animals! 🐾 Your code meets all the task requirements and constraints, and you've done well with class structure, inheritance, and list management. While the bite method currently assumes the other parameter is a Herbivore, this is not a critical issue for the current functionality. If you plan to extend the functionality in the future, consider using a more general type hint like Animal. Keep up the great work and happy coding! 🎉
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
|
|
||
| class Carnivore(Animal): | ||
| def bite(self, other: "Herbivore") -> None: |
There was a problem hiding this comment.
The type hint for the other parameter in the bite method is set to Herbivore. This could be restrictive if you later decide to allow Carnivores to bite other Carnivores or different types of animals. Consider using a more general type hint, like Animal, if you plan to extend this functionality.
No description provided.